Prefer realtime voice in Capacitor shell#569
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The web app was entering realtime correctly, but the Capacitor app started the native voice session first and returned from
activate.native-only. That meantNEXT_PUBLIC_CREWCMD_REALTIME_VOICE=1never reached/talk/realtime/sessionin the native shell.Local verification
pnpm test -- src/lib/gateway-client-realtime.test.ts src/lib/realtime-voice-client.test.ts src/lib/runtime-capabilities.test.tspnpm typecheckgit diff --check origin/main..HEADpnpm typecheck && pnpm buildManual test notes
In the Capacitor app with
NEXT_PUBLIC_CREWCMD_REALTIME_VOICE=1, activating voice should now log:POST /api/runtimes/<id>/talk/realtime/session 200/talk/realtime/relayIt should not immediately take
/api/mobile/voice-session/tokenunless realtime startup fails or realtime is disabled.