feat: add multi-account financial overview dashboard by GPradaT · Pull Request #609 · rohitdash08/FinMind

GPradaT · 2026-03-22T15:02:51Z

Summary

Implements multi-account financial overview (#132).

Features:

Manage multiple financial accounts (checking, savings, credit, cash, investment)
Aggregated overview with total balance and net worth
Net worth calculation (assets minus credit liabilities)
Per-type breakdown showing count and totals
Soft-delete (deactivation) preserves history
Color field for frontend UI differentiation

Endpoints:

Method	Path	Description
GET	`/accounts/`	List accounts (filter inactive)
POST	`/accounts/`	Create account
GET	`/accounts/overview`	Aggregated overview + net worth
GET	`/accounts/:id`	Get account
PUT	`/accounts/:id`	Update account
DELETE	`/accounts/:id`	Deactivate account

Tests: 12 tests covering CRUD, overview aggregation, soft-delete, and inactive filtering.

Closes #132

/claim #132

Implements multi-account support (rohitdash08#132): - FinancialAccount model (checking, savings, credit, cash, investment) - Full CRUD for financial accounts with soft-delete - Aggregated overview endpoint with net worth calculation - Net worth = assets - credit liabilities - Per-type breakdown (count + total) - 12 tests covering CRUD, overview, and deactivation Endpoints: GET/POST /accounts/ GET /accounts/overview GET/PUT/DELETE /accounts/:id Closes rohitdash08#132

Copilot

Pull request overview

Adds backend support for managing multiple financial accounts and retrieving an aggregated overview (total balance + net worth), including soft-deactivation and a UI color field, to support the multi-account dashboard requested in #132.

Changes:

Introduces FinancialAccount model + DB schema for persisted accounts.
Adds /accounts CRUD endpoints plus /accounts/overview aggregation endpoint.
Adds pytest coverage for CRUD, overview aggregation, and inactive filtering.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`packages/backend/tests/test_accounts.py`	New tests for accounts CRUD, overview, and inactive filtering.
`packages/backend/app/services/accounts.py`	Implements account persistence helpers and overview aggregation + serialization.
`packages/backend/app/routes/accounts.py`	Adds JWT-protected REST endpoints for accounts and overview.
`packages/backend/app/routes/__init__.py`	Registers the new accounts blueprint.
`packages/backend/app/models.py`	Adds the `FinancialAccount` SQLAlchemy model.
`packages/backend/app/db/schema.sql`	Creates the `financial_accounts` table for `init-db`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-22T15:07:43Z

packages/backend/app/routes/accounts.py

+    data = request.get_json()
+
+    if not data or not data.get("name") or not data.get("account_type"):
+        return jsonify(error="name and account_type are required"), 400
+
+    account, error = account_service.create_account(
+        user_id=user_id,
+        name=data["name"],
+        account_type=data["account_type"],
+        currency=data.get("currency", "INR"),
+        balance=data.get("balance", 0),
+        color=data.get("color"),
+    )


Input normalization is inconsistent with other endpoints: name isn’t stripped and account_type isn’t normalized (case/whitespace), so values like ' Main ' or 'Checking' will be stored/rejected unexpectedly. Consider name = (data.get('name') or '').strip() and normalizing account_type (e.g., lowercase + strip) before validating/creating.

Copilot · 2026-03-22T15:07:43Z

packages/backend/app/services/accounts.py

+        by_type[a.account_type]["count"] += 1
+        by_type[a.account_type]["total"] += float(a.balance)
+
+    # Net worth = assets - liabilities (credit accounts are negative)


The comment says "credit accounts are negative", but the API/tests treat credit balances as positive liabilities (and the code subtracts abs(liabilities) accordingly). Please update the comment to reflect the actual expected sign/meaning of balance for credit accounts to avoid confusion for future changes.

Suggested change

# Net worth = assets - liabilities (credit accounts are negative)

# Net worth = assets - liabilities (credit account balances are stored as positive liabilities)

Copilot · 2026-03-22T15:07:43Z

packages/backend/app/routes/accounts.py

+    if not account:
+        return jsonify(error="Account not found"), 404
+    return jsonify(account_service.serialize_account(account)), 200


Error messages are inconsistent with the rest of the API (most endpoints use lowercase "not found"). Consider standardizing these ("not found") to make client-side handling consistent.

Copilot · 2026-03-22T15:07:43Z

packages/backend/app/routes/accounts.py

+    user_id = get_jwt_identity()
+    include_inactive = request.args.get("include_inactive", "false").lower() == "true"
+    items = account_service.get_accounts(user_id, active_only=not include_inactive)
+    return jsonify([account_service.serialize_account(a) for a in items]), 200


All other routes cast get_jwt_identity() to int (JWT identity is created as a string in auth.login). Here user_id is left as a string, which can break DB lookups (e.g., Postgres INTEGER = VARCHAR) and cause accounts to be unreadable. Cast once per handler (user_id = int(get_jwt_identity())).

Copilot · 2026-03-22T15:07:44Z

packages/backend/app/services/accounts.py

+        return None
+
+    if "account_type" in kwargs and kwargs["account_type"] not in VALID_ACCOUNT_TYPES:
+        return None
+
+    for key in ("name", "account_type", "currency", "balance", "is_active", "color"):
+        if key in kwargs and kwargs[key] is not None:
+            setattr(account, key, kwargs[key])
+
+    db.session.commit()
+    return account


update_account returns None both when the account doesn't exist and when account_type is invalid, which forces the route layer to conflate these cases. Return a richer result (e.g., (account, error) like create_account) or raise a validation error so the route can return 400 for invalid data and 404 for missing accounts.

Suggested change

return None

if "account_type" in kwargs and kwargs["account_type"] not in VALID_ACCOUNT_TYPES:

return None

for key in ("name", "account_type", "currency", "balance", "is_active", "color"):

if key in kwargs and kwargs[key] is not None:

setattr(account, key, kwargs[key])

db.session.commit()

return account

return None, "Account not found."

if "account_type" in kwargs and kwargs["account_type"] not in VALID_ACCOUNT_TYPES:

return None, f"Invalid account type. Must be one of: {', '.join(sorted(VALID_ACCOUNT_TYPES))}"

for key in ("name", "account_type", "currency", "balance", "is_active", "color"):

if key in kwargs and kwargs[key] is not None:

setattr(account, key, kwargs[key])

db.session.commit()

return account, None

Copilot · 2026-03-22T15:07:44Z

packages/backend/app/routes/__init__.py

    app.register_blueprint(categories_bp, url_prefix="/categories")
    app.register_blueprint(docs_bp, url_prefix="/docs")
    app.register_blueprint(dashboard_bp, url_prefix="/dashboard")
+    app.register_blueprint(accounts_bp, url_prefix="/accounts")


accounts Blueprint is created with url_prefix="/accounts" and is also registered with url_prefix="/accounts" in register_routes, which will result in endpoints being mounted under /accounts/accounts/.... Remove one of the prefixes (prefer: define the blueprint without url_prefix and keep the registration prefix, consistent with other routes).

Suggested change

app.register_blueprint(accounts_bp, url_prefix="/accounts")

app.register_blueprint(accounts_bp)

Copilot · 2026-03-22T15:07:45Z

packages/backend/app/routes/accounts.py

+    account = account_service.update_account(account_id, user_id, **data)
+    if not account:
+        return jsonify(error="Account not found or invalid data"), 404


The update endpoint returns 404 for both "not found" and "invalid data". This makes client error handling ambiguous and is inconsistent with other endpoints (they return 400 for invalid input). Consider returning 400 when the payload is invalid (e.g., bad account_type) and reserving 404 strictly for missing accounts.

Suggested change

account = account_service.update_account(account_id, user_id, **data)

if not account:

return jsonify(error="Account not found or invalid data"), 404

if not data:

return jsonify(error="No data provided"), 400

account = account_service.update_account(account_id, user_id, **data)

if not account:

return jsonify(error="Account not found"), 404

Copilot · 2026-03-22T15:07:45Z

packages/backend/app/db/schema.sql

+CREATE TABLE IF NOT EXISTS financial_accounts (
+  id SERIAL PRIMARY KEY,
+  user_id INT NOT NULL REFERENCES users(id) ON DELETE CASCADE,
+  name VARCHAR(200) NOT NULL,
+  account_type VARCHAR(50) NOT NULL,
+  currency VARCHAR(10) NOT NULL DEFAULT 'INR',
+  balance NUMERIC(12,2) NOT NULL DEFAULT 0,
+  is_active BOOLEAN NOT NULL DEFAULT TRUE,
+  color VARCHAR(7),
+  created_at TIMESTAMP NOT NULL DEFAULT NOW()
+);


The new financial_accounts table is added to schema.sql, but existing Postgres deployments that rely on _ensure_schema_compatibility() won't get this table created automatically (and will 500 when hitting /accounts/*). If this repo’s intended upgrade path is to apply compatibility ALTERs in-app, consider adding a CREATE TABLE IF NOT EXISTS financial_accounts ... there as well, or otherwise document/run a migration step for upgrades.

Copilot · 2026-03-22T15:07:45Z

packages/backend/app/routes/accounts.py

+"""Financial accounts endpoints."""
+
+from flask import Blueprint, jsonify, request
+from flask_jwt_extended import jwt_required, get_jwt_identity
+
+from ..services import accounts as account_service
+
+bp = Blueprint("accounts", __name__, url_prefix="/accounts")


PR/issue acceptance criteria mention documentation updates, but the API spec (app/openapi.yaml) does not include any /accounts paths. Please add the new endpoints to the OpenAPI docs so /docs stays accurate.

Copilot · 2026-03-22T15:07:45Z

packages/backend/app/routes/accounts.py

+bp = Blueprint("accounts", __name__, url_prefix="/accounts")
+
+
+@bp.get("/")
+@jwt_required()
+def list_accounts():
+    user_id = get_jwt_identity()
+    include_inactive = request.args.get("include_inactive", "false").lower() == "true"
+    items = account_service.get_accounts(user_id, active_only=not include_inactive)
+    return jsonify([account_service.serialize_account(a) for a in items]), 200
+
+
+@bp.post("/")
+@jwt_required()
+def create_account():
+    user_id = get_jwt_identity()
+    data = request.get_json()


This module defines routes with trailing slashes (@bp.get("/"), @bp.post("/")), while the rest of the API uses no trailing slash (e.g., @bp.get("") for /categories). With Flask’s default strict_slashes, clients calling /accounts may get redirected (308). Consider aligning with existing routes by using "" instead of "/" (and update tests accordingly), or explicitly disable strict slashes for this blueprint.

…ve unused imports

…hboard Addresses Copilot review and adds missing pieces: - Frontend: Accounts page with overview cards (total balance, net worth, active count) - Frontend: Account list with type-specific icons, create dialog, soft-delete - Frontend: API client (accounts.ts) following existing pattern (bills.ts) - Frontend: Route in App.tsx + navigation link in Navbar - OpenAPI: Full /accounts paths and Account/NewAccount/AccountOverview schemas

…paration, comment fix, index

GPradaT · 2026-03-23T15:41:48Z

Demo Video

Full demo showing all three features working against a local dev server (SQLite + fakeredis):

Multi-Account Dashboard: Create accounts, net worth calculation, deactivation
Savings Goals: Create goal, contributions, progress tracking with milestones (75%)
Weekly Digest: Expense creation, digest generation, history

Download demo video

Recorded on local Kubuntu dev environment, March 23 2026.

- Apply black formatting to models.py, accounts.py, test_accounts.py - Fix Navbar test: use exact regex /^account$/i to avoid matching both "Account" and "Accounts" nav links Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 22, 2026 15:02

GPradaT requested a review from rohitdash08 as a code owner March 22, 2026 15:02

Copilot started reviewing on behalf of GPradaT March 22, 2026 15:03 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

algora-pbc bot added the 🙋 Bounty claim label Mar 22, 2026

algora-pbc bot mentioned this pull request Mar 22, 2026

Multi-account financial overview dashboard #132

Open

GPradaT added 3 commits March 22, 2026 16:40

fix: address Copilot review - url_prefix, jwt identity int cast, remo…

7b0ad04

…ve unused imports

fix: address remaining Copilot review — input normalization, error se…

59fd8d2

…paration, comment fix, index

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add multi-account financial overview dashboard#609

feat: add multi-account financial overview dashboard#609
GPradaT wants to merge 5 commits intorohitdash08:mainfrom
GPradaT:feat/multi-account-dashboard

GPradaT commented Mar 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

GPradaT commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	# Net worth = assets - liabilities (credit accounts are negative)
	# Net worth = assets - liabilities (credit account balances are stored as positive liabilities)

	app.register_blueprint(accounts_bp, url_prefix="/accounts")
	app.register_blueprint(accounts_bp)

Conversation

GPradaT commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

GPradaT commented Mar 23, 2026

Demo Video

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GPradaT commented Mar 22, 2026 •

edited

Loading