docs(hermes): correct plugin install path (#197)#205
Conversation
Hermes scans `~/.hermes/plugins/<name>/` flat. Memory category namespace (`memory/`) is reserved for bundled providers and won't discover user plugins nested under it. Closes #197
📝 WalkthroughWalkthroughDocumentation correction updating the Hermes plugin installation path from a nested directory structure ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@integrations/hermes/README.md`:
- Line 78: The package docstring in integrations/hermes/__init__.py still
references the old installation path "~/.hermes/plugins/memory/agentmemory/";
update that docstring string to match the README and use the correct
installation path "~/.hermes/plugins/agentmemory/" so documentation is
consistent (locate the top-level module docstring in
integrations/hermes/__init__.py and replace the old path substring).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 678f44dc-91ca-432b-9891-e07368ee9caa
📒 Files selected for processing (2)
README.mdintegrations/hermes/README.md
|
|
||
| ```bash | ||
| cp -r integrations/hermes ~/.hermes/plugins/memory/agentmemory | ||
| cp -r integrations/hermes ~/.hermes/plugins/agentmemory |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all references to the old nested plugin path
# Search for the old nested path pattern
rg -n "\.hermes/plugins/memory/agentmemory" --type-add 'doc:*.{md,py,txt,yaml,yml}' --type docRepository: rohitg00/agentmemory
Length of output: 158
Update the installation path in integrations/hermes/__init__.py docstring.
The README correctly updates the installation path to ~/.hermes/plugins/agentmemory/, but the docstring in integrations/hermes/__init__.py (line 4) still references the old nested path: ~/.hermes/plugins/memory/agentmemory/.
Suggested fix
"""
agentmemory memory provider for Hermes Agent.
-Drop this folder into ~/.hermes/plugins/memory/agentmemory/
+Drop this folder into ~/.hermes/plugins/agentmemory/
or install via: hermes plugin install agentmemory
Requires agentmemory server running: npx `@agentmemory/agentmemory`
"""🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integrations/hermes/README.md` at line 78, The package docstring in
integrations/hermes/__init__.py still references the old installation path
"~/.hermes/plugins/memory/agentmemory/"; update that docstring string to match
the README and use the correct installation path
"~/.hermes/plugins/agentmemory/" so documentation is consistent (locate the
top-level module docstring in integrations/hermes/__init__.py and replace the
old path substring).
Summary
~/.hermes/plugins/<name>/flat-only for memory providersmemory/category namespace is reserved for bundled providers, so user plugins nested under it are never discoveredintegrations/hermes/README.mdfrom~/.hermes/plugins/memory/agentmemoryto~/.hermes/plugins/agentmemoryThanks @LehaoLin for the precise repro and source-pointer to
plugins/memory/__init__.py.Closes #197
Test plan
~/.hermes/plugins/agentmemory/memory.provider: agentmemoryresolves on Hermes startupSummary by CodeRabbit
Documentation