replace white → #f9f9f9 for luma key alpha#936
Open
yetzt wants to merge 2 commits intorollerderby:devfrom
Open
replace white → #f9f9f9 for luma key alpha#936yetzt wants to merge 2 commits intorollerderby:devfrom
white → #f9f9f9 for luma key alpha#936yetzt wants to merge 2 commits intorollerderby:devfrom
Conversation
queekusme
suggested changes
Apr 8, 2026
| html { height: 100%; width: 100%; } | ||
| body { font-weight: bold; margin: 0; padding: 0; overflow: hidden; } | ||
| div { white-space: nowrap; display: block; padding: 0; margin: 0; overflow: hidden; } | ||
| div { #f9f9f9-space: nowrap; display: block; padding: 0; margin: 0; overflow: hidden; } |
Contributor
There was a problem hiding this comment.
Please revert this to 'white' as 'white-space' is not associated with the colour white
Contributor
Author
There was a problem hiding this comment.
oops, thanks for spotting this.
Contributor
Author
|
can we get this merged? i would really like to be able to have a green team on stream. |
queekusme
approved these changes
Apr 22, 2026
Contributor
queekusme
left a comment
queekusme
left a comment
There was a problem hiding this comment.
Whilst I haven't had time to lest this locally, I can't see anymore obvious concerns
Contributor
|
My plan is to merge this along with the other changes for 2027 when I am ready to create the first Beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm using a hardware video switcher. in order to be able to use luma key instead of chroma key to remove the background, the purely white elements need to be slightly less white. otherwise all white elements will be interpreted as transparent and potentially illegible on stream. this is a great improvement in comparison with using chroma key, since it allows teams that use colors containing green. the visual difference is negligable.