Fixed retry bug and burst issues #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 11, 2019 15:42
can create a lot of packet loss on some networks.
Now the multi_ping retry functionality works correctly. The issue was that an ICMP retry packet was sent with a new ID, but the receive function was still checking packets using old IDs. Now the remainings_id is reinitialized with the new ids during each sends. This way the receive function always used the latest ids for packet matching. The source address of the packet has also been added to the packet matching to make the request/reply match more robust.
Now the number of retry are added to the result dictionary.
joshland
pushed a commit
to joshland/multi-ping
that referenced
this pull request
Apr 9, 2020
joshland
pushed a commit
to joshland/multi-ping
that referenced
this pull request
Apr 9, 2020
jarhainx
approved these changes
Dec 30, 2021
bva2poor
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #23 and #24.