Skip to content

[Bug] Updating library results in a new game entry when another rom version is added to RomM #133

Description

@Deide

Describe the bug
A while ago, the ID of a game entry was changed to [RommId]:[Hash]. This was a good change overall - especially having the RomM ID to query from scripts and such. However, it means that if you add a new rom version (ie. a version 2, a different region or an updated patched rom) to a game's folder, the folder's calculated hash for the entry's Id changes, resulting in a duplicate game entry in Playnite.

This means the loss of play time, play count, any other customised metadata changes like sorting name on top of the annoyance of duplicated entries.

To Reproduce

  • Have a folder for a RomM game. The folder contains multiple rom varieties.
  • Have it already be added to Playnite.
  • Add a rom variant to the folder (eg. a different region).
  • Update library in Playnite.
  • See duplicate game entry added.

Expected behavior
The updated RomM entry should be reflected in the existing playnite entry. Although it's a nice feature, I think the hash portion of the ID is better removed to avoid the churn.

Additional context
RomM version: 5.2.0
Playnite Plugin version: 0.8.0, Merge Rom Revisions checked.

Other notes
In the next major version of Playnite, I believe custom metadata fields are on the table. So instead of putting the hash in the Id, you could maintain a hash in its own separate field, potentially.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions