Skip to content

[Bug] Profile's <none> supported file type causes "Illegal characters in path" #141

Description

@Sobakasu13602

Describe the bug
When downloading a multi-disc game using the built-in Xenia Canary profile, I get an error saying Illegal characters in path. The game's name and the disc files themselves don't have any illegal characters. The error also happens after it's already downloaded and extracted all of this disc files, and created the m3u file.

The issue appears to be in RomMInstallController.GetRomFiles, specifically here:

return Directory.GetFiles(installDir, "*." + fileType, SearchOption.AllDirectories);

The supported file types for the built-in Xenia Canary profile are: iso,xex,cci,cxi,elf,zar,<none>. <none> is mentioned in the Playnite docs here as representing files without extensions. It seems like the plugin is taking <none> as a literal extension though, so when it does Directory.GetFiles(installDir, "*.<none>", SearchOption.AllDirectories), it throws that exception.

I was able to work around this by creating a custom profile that omits <none>, but GetRomFiles should probably be updated to interpret <none> correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Download a multi-disc game for an emulator with <none> as a supported file type (e.g. Xenia Canary)

Expected behavior
The download should succeed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions