Repository navigation
Bump version to 0.9.0 - #137
Merged
Merged
Conversation
Prepare the 0.9.0 release: bump extension.yaml, the client version sent when pairing a device, and add the 0.9.0 package entry to the addon installer manifest. RequiredApiVersion moves to 6.17.0 to match the PlayniteSDK the plugin now builds against. Also set the assembly Version so the save sync service reports 0.9.0 instead of the default 1.0.0.0 when it registers the device, and line the test project's PlayniteSDK up with the plugin's (dependabot only scans the repo root, so it was left on 6.16.0). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
Contributor
Greptile SummaryThis PR prepares version 0.9.0 by aligning extension and assembly metadata, updating the test SDK dependency, and adding the corresponding installer-catalog entry.
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking maintainability concern around duplicated client-version reporting. The release metadata, SDK requirements, tag URL, and assembly-version propagation are aligned; the remaining issue is that QR pairing must still be manually synchronized with the assembly version in future releases. Files Needing Attention: Settings/SettingsView.xaml.cs Prompt To Fix All With AI### Issue 1
Settings/SettingsView.xaml.cs:167
**Duplicated client version**
QR pairing still uses a hard-coded version, while save-sync registration reads the version from the executing assembly. A future release could update the project version but miss this literal, causing the two registration paths to report different client versions without any build or test failure. Please derive both values from one source or add an automated consistency check.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Bump version to 0.9.0" | Re-trigger Greptile |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
QR pairing hard-coded the version string while save sync read it off the assembly, so a release could bump one and leave the other reporting a stale version to RomM with nothing to catch it. Both now read PluginVersion.Current, which formats the assembly version (built from Version in RomM.csproj) as major.minor.patch. PluginVersionTests ties that declaration to extension.yaml and asserts the installer manifest carries a package entry for the same version, so a half-finished bump fails the suite instead of shipping. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the repo for the 0.9.0 release. Minor bump, since the release ships two new features (save sync, flat installs).
Changes
extension.yaml—Version: 0.8.0→0.9.0Settings/SettingsView.xaml.cs—client_versionsent on device pairing →0.9.0manifests/installer.yaml— new0.9.0package entry,RequiredApiVersion: 6.17.0(matching the PlayniteSDK the plugin now builds against, per Bump PlayniteSDK from 6.16.0 to 6.17.0 #136),ReleaseDate: 2026-09-16RomM.csproj— set<Version>0.9.0</Version>. The save sync service reportsAssembly.GetExecutingAssembly().GetName().Versionto RomM as the device's client version; with no version property set, every 0.8.0-era client registers itself as1.0.0.0.RomM.Tests/RomM.Tests.csproj— PlayniteSDK6.16.0→6.17.0. Dependabot only scans the repo root (.github/dependabot.ymlhas a singledirectory: /), so Bump PlayniteSDK from 6.16.0 to 6.17.0 #136 left the test project a minor behind the plugin it links sources from.Draft release notes
For the GitHub release on tag
0.9.0(thebuild.ymltag trigger packs the.pext):Release steps after merge
0.9.0onmainand push it —build.ymlbuilds and packs the extension, and the.pextartifact goes on the release at thePackageUrlalready written intoinstaller.yaml.Notes
dotnet/MSBuild aren't available in this environment (net462 + WPF is Windows-only), so the build and test suite weren't run locally — CI covers both on this PR./RomM.Testsas a seconddirectoryin.github/dependabot.ymlso the test project's SDK reference stops drifting from the plugin's.🤖 Generated with Claude Code
https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
Generated by Claude Code