Skip to content

Bump version to 0.9.0 - #137

Merged
gantoine merged 3 commits into
mainfrom
claude/lucid-johnson-3zk5z8
Sep 16, 2026
Merged

gantoine merged 3 commits into
mainfrom
claude/lucid-johnson-3zk5z8

Conversation

@gantoine

Copy link
Copy Markdown
Member

Prepares the repo for the 0.9.0 release. Minor bump, since the release ships two new features (save sync, flat installs).

Changes

  • extension.yaml — Version: 0.8.0 → 0.9.0
  • Settings/SettingsView.xaml.cs — client_version sent on device pairing → 0.9.0
  • manifests/installer.yaml — new 0.9.0 package entry, RequiredApiVersion: 6.17.0 (matching the PlayniteSDK the plugin now builds against, per Bump PlayniteSDK from 6.16.0 to 6.17.0 #136), ReleaseDate: 2026-09-16
  • RomM.csproj — set <Version>0.9.0</Version>. The save sync service reports Assembly.GetExecutingAssembly().GetName().Version to RomM as the device's client version; with no version property set, every 0.8.0-era client registers itself as 1.0.0.0.
  • RomM.Tests/RomM.Tests.csproj — PlayniteSDK 6.16.0 → 6.17.0. Dependabot only scans the repo root (.github/dependabot.yml has a single directory: /), so Bump PlayniteSDK from 6.16.0 to 6.17.0 #136 left the test project a minor behind the plugin it links sources from.

Draft release notes

For the GitHub release on tag 0.9.0 (the build.yml tag trigger packs the .pext):

## What's Changed
* Add option to install ROMs flat by @matthew-pye in https://github.com/rommapp/playnite-plugin/pull/129
* Fix typos in comments, README, and addon manifests by @Avicennasis in https://github.com/rommapp/playnite-plugin/pull/135
* Bump PlayniteSDK from 6.16.0 to 6.17.0 by @dependabot in https://github.com/rommapp/playnite-plugin/pull/136
* Add save sync with the RomM server by @LxKnsy in https://github.com/rommapp/playnite-plugin/pull/131

## New Contributors
* @Avicennasis made their first contribution in https://github.com/rommapp/playnite-plugin/pull/135
* @LxKnsy made their first contribution in https://github.com/rommapp/playnite-plugin/pull/131

**Full Changelog**: https://github.com/rommapp/playnite-plugin/compare/0.8.0...0.9.0

Release steps after merge

  1. Tag 0.9.0 on main and push it — build.yml builds and packs the extension, and the .pext artifact goes on the release at the PackageUrl already written into installer.yaml.
  2. Publish the GitHub release with the notes above.

Notes

  • dotnet/MSBuild aren't available in this environment (net462 + WPF is Windows-only), so the build and test suite weren't run locally — CI covers both on this PR.
  • Worth considering separately: adding /RomM.Tests as a second directory in .github/dependabot.yml so the test project's SDK reference stops drifting from the plugin's.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax


Generated by Claude Code

Prepare the 0.9.0 release: bump extension.yaml, the client version sent when
pairing a device, and add the 0.9.0 package entry to the addon installer
manifest. RequiredApiVersion moves to 6.17.0 to match the PlayniteSDK the
plugin now builds against.

Also set the assembly Version so the save sync service reports 0.9.0 instead of
the default 1.0.0.0 when it registers the device, and line the test project's
PlayniteSDK up with the plugin's (dependabot only scans the repo root, so it
was left on 6.16.0).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR prepares version 0.9.0 by aligning extension and assembly metadata, updating the test SDK dependency, and adding the corresponding installer-catalog entry.

  • Sets the extension, assembly, and QR-pairing versions to 0.9.0.
  • Aligns the test project and installer requirement with PlayniteSDK 6.17.0.
  • Adds the 0.9.0 release URL, date, and changelog.
  • Leaves client-version reporting duplicated across two runtime sources, creating a non-blocking maintenance risk for future releases.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking maintainability concern around duplicated client-version reporting.

The release metadata, SDK requirements, tag URL, and assembly-version propagation are aligned; the remaining issue is that QR pairing must still be manually synchronized with the assembly version in future releases.

Files Needing Attention: Settings/SettingsView.xaml.cs

Fix all with Greploop Fix All in Claude Code

Prompt To Fix All With AI
### Issue 1
Settings/SettingsView.xaml.cs:167
**Duplicated client version**

QR pairing still uses a hard-coded version, while save-sync registration reads the version from the executing assembly. A future release could update the project version but miss this literal, causing the two registration paths to report different client versions without any build or test failure. Please derive both values from one source or add an automated consistency check.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Bump version to 0.9.0" | Re-trigger Greptile

Comment thread Settings/SettingsView.xaml.cs Outdated
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
QR pairing hard-coded the version string while save sync read it off the
assembly, so a release could bump one and leave the other reporting a stale
version to RomM with nothing to catch it.

Both now read PluginVersion.Current, which formats the assembly version (built
from Version in RomM.csproj) as major.minor.patch. PluginVersionTests ties that
declaration to extension.yaml and asserts the installer manifest carries a
package entry for the same version, so a half-finished bump fails the suite
instead of shipping.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyzZW17hxZuB5o1yjVm8ax
@gantoine
gantoine merged commit dae15af into main Sep 16, 2026
5 checks passed
@gantoine
gantoine deleted the claude/lucid-johnson-3zk5z8 branch September 16, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants