Skip to content

Fix mobile model picker contrast and sizing #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronak-guliani wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix mobile model picker contrast and sizing #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions packages/mobile/src/components/model-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ export function ModelPicker({ visible, onClose, anchor = null }: Props) {
const panel = useSharedValue(0)
const shade = useSharedValue(0)

const popupWidth = Math.min(windowWidth - 24, 560)
const popupHeight = Math.min(windowHeight - insets.top - insets.bottom - 24, 700)
const popupWidth = Math.round(Math.min(windowWidth - 24, 560) * 0.75)
const popupHeight = Math.round(Math.min(windowHeight - insets.top - insets.bottom - 24, 700) * 0.75)

const centerX = windowWidth / 2
const centerY = windowHeight / 2
Expand Down Expand Up @@ -453,14 +453,24 @@ export function ModelPicker({ visible, onClose, anchor = null }: Props) {
]}
>
{isLiquidGlassSupported ? (
<Glass style={[styles.surface, { borderRadius: 28 }]}>{content}</Glass>
<Glass
style={[
styles.surface,
{
borderRadius: 28,
borderColor: theme.colors.border + "c0",
},
]}
>
<View style={[styles.fill, { backgroundColor: theme.colors.surface + "f2" }]}>{content}</View>
</Glass>
) : (
<BlurView
intensity={80}
tint={theme.colors.background === "#09090b" ? "dark" : "light"}
style={[styles.surface, { borderRadius: 20, borderColor: theme.colors.border + "70" }]}
style={[styles.surface, { borderRadius: 20, borderColor: theme.colors.border + "c0" }]}
>
{content}
<View style={[styles.fill, { backgroundColor: theme.colors.surface + "f2" }]}>{content}</View>
</BlurView>
)}
</View>
Expand Down Expand Up @@ -611,6 +621,9 @@ const styles = StyleSheet.create({
overflow: "hidden",
borderWidth: StyleSheet.hairlineWidth,
},
fill: {
flex: 1,
},
header: {
flexDirection: "row",
alignItems: "center",
Expand Down
Loading