Skip to content

Remove the workaround for text values split on commas #9

Description

@odolbeau

sabre/vobject splits single-value text properties (FlatText: NOTE, FN, TITLE, BIRTHPLACE…) on unescaped commas. getValue() then returns the value escaped again, so NOTE:Line 1\nLine 2, more reads with a literal \n. Upstream fix: sabre-io/vobject#797.

When

Once sabre-io/vobject#797 is released, and we require that release (#4: the fix will most likely not be backported to 4.x).

Changes

src/VCard/Internal/PropertyReader.php (text(), marked sabre/vobject workaround:): remove the joining of the parts of a text value, and use __toString() as for other properties.

VCardDecoderTest::testTextWithCommasAndNewLinesIsUnescaped must keep passing unchanged.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions