Repository navigation
feat: Make the model mutable - #24
Merged
Merged
Conversation
Editing an imported Card meant rebuilding every object on the way, copying each of its arguments by hand. Model classes are no longer read-only: set their properties, add or remove map entries, and write the Card again. The encoders still validate the Card when they write it. clone stays shallow; the README points to myclabs/deep-copy, now suggested, for an independent copy. The importer drops the rebuilds it needed too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing an imported Card meant rebuilding every object, copying each of its arguments by hand. Model classes are no longer read-only:
readonlyremoved from the 30 classes ofsrc/Model; they stayfinal, typed, with promoted properties.clonestays shallow: the README points tomyclabs/deep-copy, added tosuggest, for an independent copy.Importer: three object rebuilds become plain assignments (withGeography()removed,linkTitles(), the JSPROP fallback inpatch()).tests/Model/EditingTest.php: decode, edit, and check the exact vCard 4.0 and JSON output.make qapasses.🤖 Generated with Claude Code