Repository navigation
fix: Keep an empty EMAIL or TEL verbatim instead of reading it as a value - #30
Merged
Merged
Conversation
…alue Nextcloud Contacts writes EMAIL;TYPE=HOME: without a value. It became an EmailAddress with an empty address, which an app matching contacts by email takes for a shared address. Like an empty ADR or NICKNAME, it is now kept in vCardProps and reported. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nextcloud Contacts writes
EMAIL;TYPE=HOME:(and sometimes an emptyTEL) for a field left blank. The decoder turned it into anEmailAddresswhoseaddressis"". An app that matches contacts by email, like Rondeto, then sees every such card as sharing one address, and merges them all into the first.Fix
An
EMAILorTELwhose value is empty (or blank) is kept verbatim invCardPropsand reported as an issue, the way an emptyADRorNICKNAMEalready is. Nothing is lost, and the property still takes its key position.Tests
testAnEmptyEmailOrPhoneIsKeptVerbatim;make qais green.🤖 Generated with Claude Code