fix: add structured logging for 5 audit gaps#255
Open
ronniegeraghty wants to merge 1 commit into
Open
Conversation
- Add slog.Info for evaluation run completion with counts and duration - Add slog.Info for config resolution with source path and config names - Add slog.Warn for workspace recovery failures (3 silenced errors) - Add file path context to report write error logs - Add slog.Info for remote skill installation completion Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes 5 logging gaps identified in the codebase audit (
plan/codebase-audit.md).Changes
Run-completion slog message (P1) —
engine.go: Addedslog.Info("Evaluation run complete", ...)with run_id, pass/fail/error counts, and duration after the evaluation loop finishes.Config resolution logging (P1) —
run.go: Addedslog.Info("Configs loaded", ...)with source path, count, and config names after configs are resolved.Workspace recovery warnings (P1) —
workspace.go: Addedslog.Warnfor 4 previously silenced errors inrecoverMisplacedFiles()(junk dir delete, cross-FS copy, cross-FS remove, file cleanup).Report write path context (P2) —
engine.go: All 3slog.Error("Failed to write...")calls now include the output directory path. Addedslog.Debugfor successful writes.Skill installation logging (P2) —
fetcher.go: Addedslog.Info("Remote skill installed", ...)after successfulnpx skills add.Testing
go test ./hyoka/cmd/...passeseval(TestBuildSessionConfig_SystemPromptWired) andpairwise(undefined fields) are unrelated