Fix number formatting when cells are empty#602
Open
ldodds wants to merge 1 commit intoroo-rb:masterfrom
Open
Conversation
This was referenced Nov 7, 2023
|
Would need this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a spreadsheet has empty cells formatted as numbers then attempting to turn the worksheet into CSV fails with an exception:
The Number class does not check whether the provided cell value is empty before attempting to parse it into a Float or format it back into a String.
In our example, the given cells in the spreadsheet had an empty String as their value, and an excelx_value of
[:numeric_or_formula, "#,##0.00"].This PR
formatted_valuemethods, which will demonstrate the bugcreate_numericto return nil if the value is empty or nil