[TCling] Do not add decls for control statements if already annotated

[devajithvs]

This Pull request:

Changes or fixes:

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #8367

[github-actions]

Test Results

    17 files      17 suites   3d 13h 21m 43s ⏱️
 2 663 tests  2 661 ✅ 0 💤 2 ❌
43 575 runs  43 573 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 1c45df8.

♻️ This comment has been updated with latest results.

[devajithvs]

Not a proper solution.

What we ideally want to do is check if a VarDecl with the same identifier is already added for the current ControlScope.

[vgvassilev]

Any chance in adding a test?

[dpiparo]

I also think a test would be good. @vgvassilev in which subdirectory would you put the simple macro which was crashing in https://github.com/root-project/roottest/tree/master/cling ?

[vgvassilev]

Maybe we can do a death test in the test folder of core/metacling.

[dpiparo]

rebased & test added

[dpiparo]

LGTM: thanks a lot for this fix. Once the tests are green, afaik we are ready to merge.

[dpiparo]

I changed the test. Before we were also testing the "line" number according to the interpreter, which can be platform dependent. Now we are independent from that

[dpiparo]

Can it be that this fix fixes also #15537 ? That's what I see, I think...

[devajithvs]

As a note, once we remove auto auto support in: #16410, this will no longer be needed and will need to be reverted.

[vgvassilev]

Lgtm!

[hahnjo]

Can it be that this fix fixes also #15537 ? That's what I see, I think...

Still fails for me. It seems important to put badcast into a macro...

[hahnjo]

Thanks!