Skip to content

[Cling] Add Cling GH CI workflow#19418

Merged
dpiparo merged 2 commits intoroot-project:masterfrom
dpiparo:gh_workflow_cling
Jul 21, 2025
Merged

[Cling] Add Cling GH CI workflow#19418
dpiparo merged 2 commits intoroot-project:masterfrom
dpiparo:gh_workflow_cling

Conversation

@dpiparo
Copy link
Copy Markdown
Member

@dpiparo dpiparo commented Jul 20, 2025

No description provided.

@dpiparo dpiparo self-assigned this Jul 20, 2025
@dpiparo dpiparo added the skip ci Skip the full builds on the actions runners label Jul 20, 2025
Comment thread interpreter/cling/.github/workflows/cling.yml Outdated
@devajithvs
Copy link
Copy Markdown
Contributor

devajithvs commented Jul 21, 2025

I put this on the back-burner for a while. I guess we can close this in favor of this then? The difference was we run on our own hosted runner. There were some failing tests on the CI (we need to disable 2 tests for the CI to pass)

@hahnjo
Copy link
Copy Markdown
Member

hahnjo commented Jul 21, 2025

I believe the two PRs are different: Here Danilo adds a workflow that will run in https://github.com/root-project/cling after a change was ported over for the standalone build. Your PR adds Cling testing inside ROOT PRs.

@devajithvs
Copy link
Copy Markdown
Contributor

I believe the two PRs are different: Here Danilo adds a workflow that will run in https://github.com/root-project/cling after a change was ported over for the standalone build. Your PR adds Cling testing inside ROOT PRs.

Ahh, I see. My bad!

Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
@dpiparo dpiparo merged commit 06819bc into root-project:master Jul 21, 2025
6 checks passed
@dpiparo dpiparo deleted the gh_workflow_cling branch July 21, 2025 15:33

- name: Configure
working-directory: build
run: cmake -DLLVM_EXTERNAL_PROJECTS=cling -DLLVM_EXTERNAL_CLING_SOURCE_DIR=../cling/ -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_TARGETS_TO_BUILD="host;NVPTX" -DCMAKE_BUILD_TYPE=Release ../llvm/llvm/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably wanted RelWithDebInfo to trigger at least asserts in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip ci Skip the full builds on the actions runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants