[tmva][sofie] Add support for parsing external ONNX data file for weights#21048
Merged
lmoneta merged 1 commit intoroot-project:masterfrom Apr 11, 2026
Merged
Conversation
Test Results 22 files 22 suites 3d 7h 50m 40s ⏱️ Results for commit 5781228. ♻️ This comment has been updated with latest results. |
sanjibansg
reviewed
Jan 30, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
Thanks for this implement, couple of comments on using a different local for loop variable.
guitargeek
changed the title
Contributor
|
This is great! It tripped me up several times that you get silently wrong results with SOFIE when you use external ONNX data files. Is there anything blocking this PR? |
lmoneta
force-pushed
the
tmva_sofie_fix_parser_external_data
branch
2 times, most recently
from
b30d212 to
941b3d1
Compare
lmoneta
requested review from
bellenot,
guitargeek and
vepadulano
as code owners
sanjibansg
approved these changes
Apr 10, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this implementation.
lmoneta
force-pushed
the
tmva_sofie_fix_parser_external_data
branch
2 times, most recently
from
986600e to
5781228
Compare
…ghts Support external_data when parsing the initialized tensor from an ONNX file To test the feture, run tutorial RMVA_SOFIE_ONNX.py changing when exporting to the ONNX file from external_data=False to external_data=True
lmoneta
force-pushed
the
tmva_sofie_fix_parser_external_data
branch
from
5781228 to
105e091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support external_data when parsing the initialized tensor from an ONNX file To test the feture, run tutorial RMVA_SOFIE_ONNX.py changing when exporting to the ONNX file from external_data=False to external_data=True