Skip to content

[hist] prevent TFormula out of bounds access#21110

Merged
vepadulano merged 6 commits intoroot-project:masterfrom
ferdymercury:patch-15
Feb 25, 2026
Merged

[hist] prevent TFormula out of bounds access#21110
vepadulano merged 6 commits intoroot-project:masterfrom
ferdymercury:patch-15

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Feb 2, 2026

This Pull request:

Changes or fixes:

Fixes #21104

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

vepadulano
vepadulano reviewed Feb 2, 2026
View reviewed changes
Comment thread hist/hist/test/test_TFormula.cxx
@ferdymercury ferdymercury marked this pull request as ready for review February 2, 2026 17:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026 •
edited
Loading

Test Results

    22 files      22 suites   3d 4h 1m 45s ⏱️
 3 795 tests  3 791 ✅ 0 💤 4 ❌
75 448 runs  75 444 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 678b360.

♻️ This comment has been updated with latest results.

@ferdymercury

This comment was marked as outdated.

Sign in to view
vepadulano
vepadulano requested changes Feb 6, 2026
View reviewed changes
Comment thread hist/hist/src/TFormula.cxx Outdated
Comment thread hist/hist/src/TFormula.cxx Outdated
Comment thread hist/hist/src/TFormula.cxx Outdated
ferdymercury
ferdymercury commented Feb 6, 2026
View reviewed changes
Comment thread hist/hist/test/test_TFormula.cxx Outdated
ferdymercury
ferdymercury commented Feb 6, 2026
View reviewed changes
Comment thread hist/hist/test/test_TFormula.cxx Outdated
ferdymercury
ferdymercury commented Feb 6, 2026
View reviewed changes
Comment thread hist/hist/src/TFormula.cxx Outdated
ferdymercury
ferdymercury commented Feb 6, 2026
View reviewed changes
Comment thread hist/hist/src/TFormula.cxx Outdated
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Feb 9, 2026

Could someone restart alma9 glitch?
Thks

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Feb 10, 2026

Thanks, looking green now.

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Feb 14, 2026

@vepadulano , do you think we can merge this PR?

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Feb 24, 2026

gentle ping also to @lmoneta

vepadulano
vepadulano requested changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes, I just noticed a small typo. Also, I think the commit history could be squashed and adjusted a bit, I will let you decide what's the best way.

Comment thread hist/hist/src/TFormula.cxx Outdated
ferdymercury
ferdymercury commented Feb 24, 2026
View reviewed changes
Comment thread hist/hist/src/TFormula.cxx Outdated
ferdymercury and others added 6 commits February 24, 2026 13:12
@ferdymercury
[hist] prevent TFormula out of bounds access
312a717 
Fixes root-project#21104

[hist] fix access when opening bracket pos exactly at length

[hist] additional out of bounds access safety guards
@ferdymercury
[test] verify that TFormula open bracket does not go into infinite loop
806278f 
[test] test also opening parenthesis
@ferdymercury
[hist] check for balanced parentheses, brackets, braces or quotes
d349548 
set IsValid to false otherwise while constructing TFormula
@ferdymercury @vepadulano
[test] TFormula unbalanced: check error detection and IsValid value
2575933 
[test] singleQuote printed string

Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com>
@ferdymercury @lmoureaux
[nfc] improve TFormula docu
dac0892 
[nfc][hist] clarify docu

[nfc] typo

vepadulano and lmoureaux thks

Co-authored-by: Louis Moureaux <m_louis30@yahoo.com>
@ferdymercury
[hist] fix restitution of parameter name containing @
678b360 
Amends root-project@dcf9209#r176468371

see also 1f1cb91

Should make TFormulaTest39 pass again

[hist] fix out of bounds access at N-th term
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Feb 25, 2026

LGTM for the changes, I just noticed a small typo. Also, I think the commit history could be squashed and adjusted a bit, I will let you decide what's the best way.

Thanks.
I fixed commit history. But it's fine for me if you decide it's better to squash all on merge.
Mac26 failure seems unrelated.
So ready to merge from my side

@vepadulano vepadulano merged commit d3d1a47 into root-project:master Feb 25, 2026
27 of 30 checks passed
@ferdymercury ferdymercury deleted the patch-15 branch February 25, 2026 10:47
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Feb 25, 2026

/backport to 6.38

@root-project-bot
Copy link
Copy Markdown

root-project-bot commented Feb 25, 2026

Something went wrong with the backport to 6.38: @dpiparo please see the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepadulano vepadulano vepadulano approved these changes

@hageboeck hageboeck Awaiting requested review from hageboeck hageboeck is a code owner

@pcanal pcanal Awaiting requested review from pcanal

@guitargeek guitargeek Awaiting requested review from guitargeek

@lmoneta lmoneta Awaiting requested review from lmoneta

+1 more reviewer

@lmoureaux lmoureaux lmoureaux left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vepadulano vepadulano

Labels

pr:squash on merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Out-of-bounds access in TFormula constructor

6 participants

@ferdymercury @dpiparo @root-project-bot @pcanal @vepadulano @lmoureaux