[df] Support std::array data members in TTree schemas#21278
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Apr 21, 2026
Merged
[df] Support std::array data members in TTree schemas#21278dpiparo merged 1 commit intoroot-project:masterfrom
dpiparo merged 1 commit intoroot-project:masterfrom
Conversation
vepadulano
force-pushed
the
rdf-vector-class-array-data-member
branch
from
18f049f to
58db28a
Compare
Test Results 22 files 22 suites 3d 11h 43m 39s ⏱️ Results for commit 6b0673c. ♻️ This comment has been updated with latest results. |
vepadulano
force-pushed
the
rdf-vector-class-array-data-member
branch
2 times, most recently
from
8cd1734 to
f4dc20c
Compare
vepadulano
requested review from
bellenot,
dpiparo,
martamaja10 and
pcanal
as code owners
Member
Author
|
Marking the PR ready for review as all the wanted changes are there. There is a leftover failure on Windows related to an issue with CMake that has been understood and will be dealt with in a separate PR (that will become a requirement for this one). |
vepadulano
force-pushed
the
rdf-vector-class-array-data-member
branch
from
f4dc20c to
1595432
Compare
pcanal
reviewed
Feb 24, 2026
pcanal
reviewed
Feb 24, 2026
pcanal
reviewed
Feb 24, 2026
pcanal
reviewed
Feb 24, 2026
Fixes root-project#14790 Include tests that both check the fixed behaviour and document limitations and currently unsupported schemas or operations on them that are closely related to the one described above. Reading of the same TTree schema with RNTuple is currently not supported within this context.
vepadulano
force-pushed
the
rdf-vector-class-array-data-member
branch
from
1595432 to
6b0673c
Compare
Member
Author
|
@dpiparo I would like to propose for this bugfix to be included in 6.40 |
Member
|
moved to rc1 |
Member
|
/backport to 6.36, 6.38 |
Member
|
/backport to 6.38 |
|
This PR has been backported to branch 6.38: #22007 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14790
Include tests that both check the fixed behaviour and document limitations and currently unsupported schemas or operations on them that are closely related to the one described above.
Note that this PR shows the testing infrastructure for the equivalent RNTuple schemas, but provides no support for it. After internal discussion, it has become evident that the RNTuple data source would need more work for support of partial reading of class data members with types different than the on-disk one.
Note for posterity
Another approach could have been to standardise in which way RDF can read collection types such as the ones addressed in this PR. This was proposed and discussed at PPP194 https://indico.cern.ch/event/1660527/ . After discussion, the proposal was rejected. Find more details in the minutes attached to the agenda.