Skip to content

[ntuple] add tutorial for low-precision float fields#21318

Merged
silverweed merged 4 commits intoroot-project:masterfrom
silverweed:ntuple_tutorial_lowprecfloat
Feb 24, 2026
Merged

[ntuple] add tutorial for low-precision float fields#21318
silverweed merged 4 commits intoroot-project:masterfrom
silverweed:ntuple_tutorial_lowprecfloat

Conversation

@silverweed
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2026

Test Results

    22 files      22 suites   3d 6h 57m 18s ⏱️
 3 799 tests  3 797 ✅ 0 💤 2 ❌
75 510 runs  75 508 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 1a9151a.

♻️ This comment has been updated with latest results.

Comment thread tutorials/io/ntuple/ntpl018_low_precision_floats.C Outdated
@silverweed silverweed force-pushed the ntuple_tutorial_lowprecfloat branch from df6d583 to d1905b7 Compare February 19, 2026 16:22
Copy link
Copy Markdown
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Copy Markdown
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please also update the index.md in the parent directory.

Possibly: the tutorial could create a plot that shows how a distribution becomes fuzzier at lower precision (but then perhaps one should also print space savings).

Comment thread tutorials/io/ntuple/ntpl018_low_precision_floats.C Outdated
Comment thread tutorials/io/ntuple/ntpl018_low_precision_floats.C Outdated
Comment thread tutorials/io/ntuple/ntpl018_low_precision_floats.C
@silverweed
Copy link
Copy Markdown
Contributor Author

Possibly: the tutorial could create a plot that shows how a distribution becomes fuzzier at lower precision (but then perhaps one should also print space savings).

I think in the case of a specialized tutorial like this "less is more", so I'd rather limit the code not related to how the feature is used to a minimum..

@silverweed silverweed requested a review from jblomer February 23, 2026 09:09
Comment thread tutorials/io/ntuple/ntpl018_low_precision_floats.C Outdated
@silverweed silverweed force-pushed the ntuple_tutorial_lowprecfloat branch from 84d897b to fa8d21d Compare February 24, 2026 07:55
@silverweed silverweed force-pushed the ntuple_tutorial_lowprecfloat branch from fa8d21d to 1a9151a Compare February 24, 2026 07:58
@silverweed silverweed merged commit 755da63 into root-project:master Feb 24, 2026
28 of 30 checks passed
@silverweed silverweed deleted the ntuple_tutorial_lowprecfloat branch February 24, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants