Skip to content

[v638][CPyCppyy] Add wchar_t*_Nonnull converter for libc++ std::wstring ctors #21353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 1 commit into from
Feb 24, 2026
Merged

[v638][CPyCppyy] Add wchar_t*_Nonnull converter for libc++ std::wstring ctors #21353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bindings/pyroot/cppyy/CPyCppyy/src/Converters.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3641,6 +3641,17 @@ static struct InitConvFactories_t {
gf["char[]"] = (cf_t)+[](cdims_t d) { return new NonConstCStringArrayConverter{d, true}; };
gf["signed char*"] = gf["char*"];
gf["wchar_t*"] = (cf_t)+[](cdims_t) { return new WCStringConverter{}; };
// TODO: The libc++ library that is used most prominently by Apple for
// macOS is using the _Nonnull Clang attribute for some of its string
// constructors (_LIBCPP_DIAGNOSE_NULLPTR is a preprocessor macro that
// resolves to _Nullable). The cppyy backend doesn't strip away such Clang
// attributes, so the wchar_t* converter fails to match. To make the
// construction of std::wstring work on macOS, we are explicitly creating
// a converter for the wchar_t*_Nonnull type here, but we should try to
// find a more general solution for dealing with Clang attributes.
// [1] https://clang.llvm.org/docs/AttributeReference.html#id656
// [2] https://github.com/llvm/llvm-project/blob/2078da43e25a4623cab2d0d60decddf709aaea28/libcxx/include/string#L1061
gf["wchar_t*_Nonnull"] = (cf_t)+[](cdims_t) { return new WCStringConverter{}; };
gf["char16_t*"] = (cf_t)+[](cdims_t) { return new CString16Converter{}; };
gf["char16_t[]"] = (cf_t)+[](cdims_t d) { return new CString16Converter{dims2stringsz(d)}; };
gf["char32_t*"] = (cf_t)+[](cdims_t) { return new CString32Converter{}; };
Expand Down
Loading