Skip to content

Allow to create a TGraph2D with 0 points#21368

Merged
couet merged 2 commits intoroot-project:masterfrom
couet:graf2d-n0
Feb 25, 2026
Merged

Allow to create a TGraph2D with 0 points#21368
couet merged 2 commits intoroot-project:masterfrom
couet:graf2d-n0

Conversation

@couet
Copy link
Copy Markdown
Member

@couet couet commented Feb 24, 2026

This PR allows to create a TGraph2D with 0 points

Fixes #21366

Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
For symmetry, I'd recommend doing the same in TGraph2DErrors, TGraph2DAsymmErrors

@couet
Copy link
Copy Markdown
Member Author

couet commented Feb 24, 2026

Thanks! For symmetry, I'd recommend doing the same in TGraph2DErrors, TGraph2DAsymmErrors

done

@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 4h 56m 53s ⏱️
 3 796 tests  3 792 ✅ 0 💤 4 ❌
75 468 runs  75 464 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit dd04591.

Copy link
Copy Markdown
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a better description for the commits, possibly squashing into one and writing

Allow creating TGraph2D* classes  with 0 points

@couet couet merged commit 17d0686 into root-project:master Feb 25, 2026
26 of 30 checks passed
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Feb 25, 2026

/backport to 6.38

@root-project-bot
Copy link
Copy Markdown

Something went wrong with the backport to 6.38: @dpiparo please see the logs

@jmcarcell
Copy link
Copy Markdown
Contributor

This doesn't seem to have been backported to 6.38, @dpiparo

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Mar 5, 2026

it was, manually by @couet b3b1392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TGraph2D::Build function may leave the newly created object in inconsistent non-initialised state

6 participants