[cmake] Builtins: more uniform CMake configurations#21688
Merged
dpiparo merged 4 commits intoroot-project:masterfrom Mar 26, 2026
Merged
[cmake] Builtins: more uniform CMake configurations#21688dpiparo merged 4 commits intoroot-project:masterfrom
dpiparo merged 4 commits intoroot-project:masterfrom
Conversation
Collaborator
|
Thanks!! |
Test Results 22 files 22 suites 3d 4h 58m 15s ⏱️ For more details on these failures, see this check. Results for commit 3787a90. ♻️ This comment has been updated with latest results. |
namely freetype, libgif, libjpeg, libpng, lz4, lzma, zlib, zstd See https://cmake.org/cmake/help/latest/manual/cmake-modules.7.html
dpiparo
force-pushed
the
unifirm_builtin_bundle
branch
from
a658760 to
b1db9e9
Compare
in case the library is not found on the system.
dpiparo
force-pushed
the
unifirm_builtin_bundle
branch
from
b1db9e9 to
3787a90
Compare
Member
Author
|
The failure on ubu24 is unrelated |
Member
|
I think this logic is flawed: It makes mandatory FreeType, GIF, JPEG, PNG which are not needed for a |
ferdymercury
added a commit
to ferdymercury/root
that referenced
this pull request
Mar 30, 2026
Member
Author
|
and you are right. This was not intended. |
dpiparo
pushed a commit
that referenced
this pull request
Mar 30, 2026
harz05
pushed a commit
to harz05/root
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.