Skip to content

Increase the number of includes in countIncludePaths.C#21932

Merged
guitargeek merged 2 commits intoroot-project:masterfrom
jmcarcell:increate-includes
Apr 17, 2026
Merged

Increase the number of includes in countIncludePaths.C#21932
guitargeek merged 2 commits intoroot-project:masterfrom
jmcarcell:increate-includes

Conversation

@jmcarcell
Copy link
Copy Markdown
Contributor

@jmcarcell jmcarcell commented Apr 16, 2026

Recently, in LCG stacks we stopped using builtins in ROOT and this test stopped working, probably because there are more include paths now.

These are the list of includes that the macro reports:

-I/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/include
-I/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/meta
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/Vc/1.4.5/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/vdt/0.4.4/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc/"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc//cling"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/etc//cling/plugins/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/pcre2/10.42/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/xxHash/0.8.3/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/tbb/2022.2.0/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/jsonmcpp/3.12.0/x86_64-el9-gcc13-dbg/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT-HEAD-build/roottest/root/meta".

We get 13, but it's true we can remove the one from vc, so I'm requesting 12. The ones for pcre2, xxHash, tbb and jsonmpp (nlohmann-json) come from dependencies; at least pcre2 and xxHash may not have been there before. The ones from Vc and vdt are what we have in ROOT_INCLUDE_PATH before running the tests, I think the rest it is not us who are setting them. I'm not sure if a thorough investigation is worth it for this test.

@jmcarcell jmcarcell requested a review from dpiparo as a code owner April 16, 2026 09:26
@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 4h 6m 21s ⏱️
 3 833 tests  3 832 ✅  1 💤 0 ❌
76 555 runs  76 537 ✅ 18 💤 0 ❌

Results for commit 4f83fbc.

Copy link
Copy Markdown
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guitargeek guitargeek merged commit eb1de6f into root-project:master Apr 17, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants