[win32] suppress compiler warnings#21992
Merged
linev merged 3 commits intoroot-project:masterfrom Apr 23, 2026
Merged
Conversation
Windows complains that return value from std::make_unique is ignored
Windows complain about unreferenced local variable
Windows issue C4804 warning with unsafe type of 'bool' operation
bellenot
reviewed
Apr 21, 2026
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
LGTM, but I'll let the final word to the other reviewers
jblomer
reviewed
Apr 21, 2026
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
Fine for RNTupleDS. It relies on the fact that ROOT::NTupleSize_t has the same range than uint64_t (the biggest unsigned integer). To be pedantic, we could also statically assert that fact, but I think it is fine as is.
Member
Author
|
Can you approve? Two other changes are in the tests and just suppress warnings about unused variable and ignored return value |
Test Results 22 files 22 suites 3d 11h 48m 15s ⏱️ For more details on these failures, see this check. Results for commit 6b8302f. |
bellenot
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appears in ROOT build.