[tasimage] fix copy constructor, optimize GetMask#22027
Merged
linev merged 3 commits intoroot-project:masterfrom Apr 24, 2026
Merged
[tasimage] fix copy constructor, optimize GetMask#22027linev merged 3 commits intoroot-project:masterfrom
linev merged 3 commits intoroot-project:masterfrom
Conversation
Allocate smaller buffer for bits use std::vector<char>
Correctly check source image to clone fScaledImage or fGreyImage Fix memory leak in assign operator - fScaledImage was cloned twice
Use everywhere to cleanup scaled image
Test Results 22 files 22 suites 3d 5h 6m 40s ⏱️ For more details on these failures, see this check. Results for commit bd3deb0. ♻️ This comment has been updated with latest results. |
couet
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy constructor and assign operator implemented wrongly.
One should check source img to clone fScaledImage or fGreyImage
Fix memory leak in assign operator - fScaledImage was cloned twice
Optimize GetMask() method - required buffer size is 8 times smaller
Provide
DestroyScaledImage()method to unify way how image is destroyed