[roottest] use less ROOTSYS#22032
Open
ferdymercury wants to merge 3 commits intoroot-project:masterfrom
Open
Conversation
there are still other places where it is used such as LIBDIR
Test Results 22 files 22 suites 3d 8h 31m 11s ⏱️ For more details on these failures, see this check. Results for commit 18ef872. ♻️ This comment has been updated with latest results. |
Member
|
This is the right direction to go. Maybe @guitargeek wants to chime in with his packaging expertise, given that in these cases, the coverage guaranteed by the CI is not always enough. |
ferdymercury
commented
Apr 24, 2026
| set(ROOT_genreflex_CMD ${ROOTSYS}/bin/genreflex.exe) | ||
| set(ROOT_rootcint_CMD ${ROOTSYS}/bin/rootcint.exe) | ||
| set(ROOT_rootcling_CMD ${ROOTSYS}/bin/rootcling.exe) | ||
| set(ROOT_root_CMD ${ROOT_BINDIR}/root.exe) |
Collaborator
Author
There was a problem hiding this comment.
All these could be changed to TARGET_FILE:genexpr if you prefer
ferdymercury
commented
Apr 24, 2026
| set(ROOT_rootcling_CMD ${ROOTSYS}/bin/rootcling.exe) | ||
| set(ROOT_root_CMD ${ROOT_BINDIR}/root.exe) | ||
| set(ROOT_hadd_CMD ${ROOT_BINDIR}/hadd.exe) | ||
| set(ROOT_genreflex_CMD ${ROOT_BINDIR}/genreflex.exe) |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| set(ROOT_genreflex_CMD ${ROOT_BINDIR}/genreflex.exe) | |
| set(ROOT_genreflex_CMD $<TARGET_FILE:genreflex>) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.