Open
Conversation
jblomer
requested review from
ferdymercury
and removed request for
bellenot,
dpiparo and
pcanal
Use UUIDv4 in TDirectory (hence in TDirectoryFile and TFile) and in the RMiniFile. Note that TDirectory is used without gSystem (needed for GetCryptoRandom()) in the context of rootcling. In principle, GetCryptoRandom() should work without a TSystem object. That may be for a later commit. The UUIDv4, unlike the current UUIDv1, is (with high enough probability) globally unique.
jblomer
requested review from
dpiparo,
hahnjo,
pcanal and
silverweed
and removed request for
ferdymercury and
hahnjo
pcanal
reviewed
Apr 23, 2026
Comment on lines
+55
to
+56
| // In the context of rootcling, we don't have gSystem | ||
| if (gSystem) |
Member
There was a problem hiding this comment.
Suggested change
| // In the context of rootcling, we don't have gSystem | |
| if (gSystem) | |
| // Fallback to the default constructed TUUID if we | |
| // get here before gSystem is initialized. | |
| if (gSystem) |
Test Results 22 files 22 suites 3d 11h 29m 1s ⏱️ For more details on these failures, see this check. Results for commit f17534b. |
Member
|
Impressive PR: thanks for it. It should be backported until 6.36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use UUIDv4 in TDirectory (hence in TDirectoryFile and TFile) and in the RMiniFile. Note that TDirectory is used without gSystem (needed for GetCryptoRandom()) in the context of rootcling. In principle, GetCryptoRandom() should work without a TSystem object. That may be for a later PR.
The UUIDv4, unlike the current UUIDv1, is (with high enough probability) globally unique.
Also fixes a race in TUUID::AsString().
Fixes #22015
Replaces #22016