[RF] Bring vectorizing EvalBackends to createChi2 / chi2FitTo#22036
Draft
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Draft
[RF] Bring vectorizing EvalBackends to createChi2 / chi2FitTo#22036guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
The `createChi2()` / `chi2FitTo()` so far always went through the legacy `RooChi2Var`. This commit wires them up to the same evaluation pipeline that `createNLL()` uses, so all of Cpu, Cuda, Codegen and CodegenNoGrad backend now work for chi-squared fits.
Test Results 22 files 22 suites 3d 6h 51m 47s ⏱️ For more details on these failures, see this check. Results for commit 1d3623b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
createChi2()/chi2FitTo()so far always went through the legacyRooChi2Var. This commit wires them up to the same evaluation pipeline thatcreateNLL()uses, so all of Cpu, Cuda, Codegen and CodegenNoGrad backend now work for chi-squared fits.