Open
Conversation
Do not automatically terminate application Use gSystem->RedirectOutput
To correctly run gui classes, gVirtualX->CreateGC should return every time unique value. Otherwise cleanup of many classes does not work correctly.
Test Results 22 files 22 suites 3d 9h 35m 52s ⏱️ For more details on these failures, see this check. Results for commit b67cd71. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI classes requires that
gVirtualX->CreateGC()returns unique value.This id value identify
TGGCinstance and used to cleanup these instances at the end.If returned value always 0 - cleanup does not work correctly and may crash ROOT during teardown.
In fitpanel UnitTesting provide special subclass of
TVirtualXwhich returns unique ids.Maybe such workaround can be directly add to base
TVirtualXclass.Also modernize UnitTesting - use
gSystem->RedirectOutputto redirect standard output to the file.