Skip to content

[gui] fix crash when pictures missing in TGButton classes#22040

Merged
linev merged 1 commit intoroot-project:masterfrom
linev:gui_fixes
Apr 24, 2026
Merged

[gui] fix crash when pictures missing in TGButton classes#22040
linev merged 1 commit intoroot-project:masterfrom
linev:gui_fixes

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Apr 24, 2026

While debugging fitpanel test saw crash when image was not there.

Just prevent use of nullptr

@linev linev self-assigned this Apr 24, 2026
@linev linev requested a review from bellenot as a code owner April 24, 2026 05:56
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. These changes I had also made in #21882 (comment) but then I removed and force-pushed since we thought the problem was due to TASImage.

Comment thread gui/gui/src/TGButton.cxx
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick

@github-actions
Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 8h 44m 53s ⏱️
 3 850 tests  3 798 ✅  1 💤 51 ❌
76 004 runs  75 935 ✅ 18 💤 51 ❌

For more details on these failures, see this check.

Results for commit daa336c.

@linev linev closed this Apr 24, 2026
@linev linev deleted the gui_fixes branch April 24, 2026 10:27
@linev linev restored the gui_fixes branch April 24, 2026 10:28
@linev linev reopened this Apr 24, 2026
@linev linev merged commit 31ab719 into root-project:master Apr 24, 2026
57 of 62 checks passed
@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22049

@dpiparo dpiparo added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Apr 24, 2026
@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22050

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22051

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22052

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

1 similar comment
@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22053

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22054

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22055

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22056

@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Apr 24, 2026

/backport to 6.40

@root-project-bot
Copy link
Copy Markdown

Preparing to backport PR #22040 to branch 6.40 requested by dpiparo

@root-project-bot
Copy link
Copy Markdown

This PR has been backported to branch 6.40: #22058

@dpiparo dpiparo removed the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants