Skip to content

[tmva][sofie][gsoc] Add InstanceNormalization operator#8885

Closed
AaradhyaSaxena wants to merge 4 commits intoroot-project:masterfrom
AaradhyaSaxena:InstanceNorm
Closed

[tmva][sofie][gsoc] Add InstanceNormalization operator#8885
AaradhyaSaxena wants to merge 4 commits intoroot-project:masterfrom
AaradhyaSaxena:InstanceNorm

Conversation

@AaradhyaSaxena
Copy link
Copy Markdown
Contributor

This Pull request:

Development of the Instance Normalization operator for the Google Summer of Code 2021 project Inference Code Generation for Batch Normalization.
Depends on #8882

Checklist:

  • [ x] tested changes locally

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@AaradhyaSaxena AaradhyaSaxena changed the title Instance norm [GSoC][TMVA][SOFIE] Add InstanceNormalization operator Aug 23, 2021
@lmoneta
Copy link
Copy Markdown
Member

lmoneta commented Aug 23, 2021

@phsft-bot build just on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-ubuntu2004/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-08-23T15:39:53.276Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 32] from the object at ‘onnx::TensorProto_Segment_default_instance’ is out of the bounds of referenced subobject ‘onnx::TensorProto_Segment::begin’ with type ‘long int’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.276Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Tensor_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Tensor::shape’ with type ‘onnx::TensorShapeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.276Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Map_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Map::value_type’ with type ‘onnx::TypeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.276Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [49, 56] from the object at ‘onnx::SparseTensorProto_default_instance’ is out of the bounds of referenced subobject ‘onnx::SparseTensorProto::values’ with type ‘onnx::TensorProto*’ at offset 40 [-Warray-bounds]
  • [2021-08-23T15:39:53.276Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [73, 80] from the object at ‘onnx::TrainingInfoProto_default_instance’ is out of the bounds of referenced subobject ‘onnx::TrainingInfoProto::initialization’ with type ‘onnx::GraphProto*’ at offset 64 [-Warray-bounds]
  • [2021-08-23T15:39:53.553Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 32] from the object at ‘onnx::TensorProto_Segment_default_instance’ is out of the bounds of referenced subobject ‘onnx::TensorProto_Segment::begin’ with type ‘long int’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.553Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Tensor_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Tensor::shape’ with type ‘onnx::TensorShapeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.553Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [25, 28] from the object at ‘onnx::TypeProto_Map_default_instance’ is out of the bounds of referenced subobject ‘onnx::TypeProto_Map::value_type’ with type ‘onnx::TypeProto*’ at offset 16 [-Warray-bounds]
  • [2021-08-23T15:39:53.554Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [49, 56] from the object at ‘onnx::SparseTensorProto_default_instance’ is out of the bounds of referenced subobject ‘onnx::SparseTensorProto::values’ with type ‘onnx::TensorProto*’ at offset 40 [-Warray-bounds]
  • [2021-08-23T15:39:53.554Z] /usr/include/x86_64-linux-gnu/bits/string_fortified.h:71:33: warning: ‘void* _builtin_memset(void*, int, long unsigned int)’ offset [73, 80] from the object at ‘onnx::TrainingInfoProto_default_instance’ is out of the bounds of referenced subobject ‘onnx::TrainingInfoProto::initialization’ with type ‘onnx::GraphProto*’ at offset 64 [-Warray-bounds]

And 12 more

@guitargeek guitargeek changed the title [GSoC][TMVA][SOFIE] Add InstanceNormalization operator [tmva][sofie][gsoc] Add InstanceNormalization operator Dec 4, 2025
@guitargeek
Copy link
Copy Markdown
Contributor

A test was missing here, which is I guess the reason why the PR didn't proceed. Also, there are many merge conflicts not, there was no initial review, and there is a successor PR, which took this original PR as inspiration.

I suggest to close this PR as is it replaced by the new one, which also includes a test. Thank you for this initial proposal!

@guitargeek guitargeek closed this Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants