ci: run release gates on every pull request - #4
Merged
rootkiller6788 merged 1 commit intoSep 12, 2026
Merged
Conversation
CONTRIBUTING asks for a green CI before merge, but the only workflow is release.yml, which fires on v* tags. A contributor cannot see whether cargo test, clippy, tsc, or the instance_system integration suite still pass on a branch, and the three frontend vitest files never run in automation at all. This adds ci.yml on pull_request and push to main. It reuses the same windows-latest job shape as release — pnpm 11.18.0, Node 22, stable Rust with clippy, Swatinem/rust-cache — and runs the four release gates plus vitest. rustfmt is deliberately left out: release does not gate on it yet, and turning it on here would fail the PR on whatever the current tree happens to look like. The ignored real-machine e2e walks stay local, per the existing convention. While touching the contributing docs: CONTRIBUTING linked plan.md and TODO.md, neither of which is in the repo, and README still listed a docs/ directory that does not exist. Point the intro and the language- boundary note at this file instead, say that ci.yml is what runs the PR gates, and close issues from the PR body rather than a TODO checkbox.
Owner
|
Yes, merge it — it's workflow-and-docs only, and I verified every premise is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CONTRIBUTING requires a green CI before merge, but the only workflow in
.github/workflows/isrelease.yml, which only runs onv*tags. Contributors cannot tell whethercargo test, clippy,tsc, or theinstance_systemsuite still pass on a branch, and the three frontend vitest files never run in automation.Two docs also point at files that are not in the repo:
CONTRIBUTING.mdlinksplan.md/TODO.md, andREADME.mdlists adocs/directory that does not exist.What
.github/workflows/ci.ymlonpull_requestandpushtomain.windows-latestjob shape asrelease.yml(pnpm 11.18.0, Node 22, stable Rust + clippy,Swatinem/rust-cache).npx vitest runinapps/desktop.rustfmtout for now — release does not gate on it, and enabling it here would fail on the current tree.CONTRIBUTING.mddead links (plan.md,TODO.md, "P2" placeholder → points atci.yml).docs/line from the README tree.How tested
ci.ymlcopies the already-shipping release gate commands.mcpConfig.test.ts,theme.test.ts,appStore.test.tsunderapps/desktop/src.Happy to adjust the job matrix or add
cargo fmt --checkin a follow-up once the tree is formatted.