Faster cc_sea(): switched terra:extract to terra:relate#108
Merged
azizka merged 3 commits intoropensci:masterfrom May 27, 2025
Merged
Faster cc_sea(): switched terra:extract to terra:relate#108azizka merged 3 commits intoropensci:masterfrom
azizka merged 3 commits intoropensci:masterfrom
Conversation
In my tests this decreased the processing time for 10K records from 94 seconds to < 1 second.
Errors in tests due to naturalearth using CN-TW for Taiwan, GBIF using TW. Also -99 wasn't handled as a missing data value.
`relate` isn't availbe in the package Namespace, needs to be located in `terra::`.
Collaborator
|
Looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my tests this decreased the processing time for 10K records from 94 seconds to < 1 second. I didn't look too carefully at the logic in that function, after determining that it was the call to terra:extract that was taking up all the time, and terra:relate could be made to accomplish the same thing in a tiny fraction of the time.
I ran your tests and everything came back fine (except for an unrelated issue with cc_outl and Taiwan?).