Fix VCR examples for VCR off

[maelle]

cc @drmowinckels

This is not tested and not enough.

When I try to run examples that use vcr when VCR is off, I get the error:

Error in `cassette$file()`:
! attempt to apply non-function

from https://github.com/ropensci/vcr/blob/42fad406bf43519ffa535ee2316082339fc3bbf8/R/examples.R#L61C3-L61C26

So some earlier escaping is needed.

But a remaining problem is that if no cassette is inserted, vcr::eject_cassette() errors.

In local_cassette(), the ejecting function is called conditionally.

vcr/R/use_cassette.R

Line 146 in 42fad40

if (!is.null(cassette)) {

Maybe vcr::eject_cassette() should also have an early return() when vcr is off? Thoughts?

[sckott]

thanks @maelle

[maelle]

@sckott do you think this is a correct fix?

[sckott]

Sorry for delay @maelle - I was trying to figure it out locally for a while, then got busy with work and life. I'll look again ASAP

[maelle]

Friendly reminder, but no pressure 😸

[sckott]

Hey @maelle can you review now? Added the eject_cassette early return, and added a test. What do you think?

[maelle]

thanks!!

[maelle]

@sckott friendly reminder 😸

[sckott]

@maelle fixed that last thing in the test. Can you take a look? Or did you already think it was good to go?

[drmowinckels]

I'm quite certain that fixes the issue for my part (tried cmd check in vanilla mode and everything went fine)

[maelle]

Thanks both! @sckott I'll rebase #548 after you merge as I think its builds are red for the same reason.