Conversation
|
@maelle nice! should i look for the current state of this branch or do you want to do more first? |
|
I will do more first! |
|
@sckott this PR was sort of an experiment, I worked with Claude CLI! I think it's ready for review. 😸 |
|
A bit confused by the test error that is unrelated to my changes?! ══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-lightswitch.R:16:5'): turned_off works if and only if no cassettes active ──
Adding new snapshot:
Code
turned_off(5 + 5)
Condition
Error in `turn_off()`:
! You must eject all cassettes before you can turn vcr off.
Backtrace:
▆
1. └─base::eval(...)
2. └─base::eval(...)
3. └─testthat::expect_snapshot(turned_off(5 + 5), error = TRUE) at test-lightswitch.R:16:5
[ FAIL 1 | WARN 0 | SKIP 1 | PASS 598 ]
Error:
! Test failures.
Execution halted |
|
Same failure in #554 that has no real edit, maybe due to the new testthat version? |
|
Ah yes
I'll make a commit to main! |
|
great i'll take a look soon! |
sckott
left a comment
There was a problem hiding this comment.
Looks good so far. I'm still poking around.
Shouldn't there be a man/delete_cassettes.Rd file? Can you add that please
|
@sckott done, sorry about the delay 😸 |
Fix #552
Not ready, will need a second pass