Add RPM templates for 'cargo' build type - #763
Merged
Merged
Conversation
Blast545
reviewed
Apr 14, 2026
Contributor
There was a problem hiding this comment.
I'm not quite familiar with bloom, so I made a first pass review by comparing this file to https://github.com/ros-infrastructure/bloom/blob/master/bloom/generators/rpm/templates/ament_python/template.spec.em and making sure the flow of the process sounds reasonable. For now LGTM after clarification questions.
Is there a "simple" way to test locally if this works? 👀
cottsay
commented
May 8, 2026
cottsay
marked this pull request as ready for review
July 23, 2026 16:06
cottsay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
cargobuild type, and onlyrpmtemplates at this stage.