Drop 'path' from Cargo dependencies during rebase - #777
Merged
Conversation
The Bloom rebasing process involves trimming the repository contents to only include the package being released. Cargo manifests can reference other packages in the repository using a 'path' value as part of the dependency spec, which is no longer valid. Remove all 'path' values from dependencies and add a placeholder 'version' value if one is not already present such that the manifest is still valid.
cottsay
force-pushed
the
cottsay/normalize-cargo
branch
from
June 26, 2026 16:15
5e1e253 to
8c5ed8c
Compare
Blast545
approved these changes
Jun 26, 2026
Blast545
left a comment
Blast545
left a comment
Contributor
There was a problem hiding this comment.
Small typo, otherwise LGTM
Co-authored-by: Jorge J. Perez <j.j.perez13@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bloom rebasing process involves trimming the repository contents to only include the package being released. Cargo manifests can reference other packages in the repository using a 'path' value as part of the dependency spec, which is no longer valid.
Remove all 'path' values from dependencies and add a placeholder 'version' value if one is not already present such that the manifest is still valid.
Eventually, we'll want this normalization process to be more involved so that we can de-workspace the cargo packages as well. This is done as part of
cargo packageandcargo read-manifest.I'm not 100% certain that this is the right place to do this. Maybe it should be an implicit patch, or should be moved to
rosrelease.py, or should maybe be conditional on detecting a package of typecargoorament_cargo. I'm open to suggestions.