Skip to content

add detectron2 detector#17

Open
tony23545 wants to merge 16 commits intoros-navigation:masterfrom
tony23545:master
Open

add detectron2 detector#17
tony23545 wants to merge 16 commits intoros-navigation:masterfrom
tony23545:master

Conversation

@tony23545
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small things

Comment thread detectron2_detector/README.md Outdated
Comment thread detectron2_detector/README.md Outdated
Comment thread detectron2_detector/detectron2_detector/detectron2_node.py
Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little thing - though I'd like to get running on the Jetson before merging this and update it with anything required to make that work

detectron_score_thresh: 0.8
# processing parameters
pointcloud2_topic: "/camera/depth/points"
categories: [0] # please check out COCO dataset category_id list if you want to config this; if you want to track all, leave it empty
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this by line number in the COCO file or by string? If by line #, mention that in the readme. That's probably obvious to AI engineers but probably not for robotics engineers

@SteveMacenski
Copy link
Copy Markdown
Member

@tony23545 any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants