add detectron2 detector#17
Open
tony23545 wants to merge 16 commits intoros-navigation:masterfrom
Open
Conversation
merge update to branch
Detection dev
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Looks good, just a couple small things
SteveMacenski
requested changes
Oct 15, 2020
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Last little thing - though I'd like to get running on the Jetson before merging this and update it with anything required to make that work
| detectron_score_thresh: 0.8 | ||
| # processing parameters | ||
| pointcloud2_topic: "/camera/depth/points" | ||
| categories: [0] # please check out COCO dataset category_id list if you want to config this; if you want to track all, leave it empty |
Member
There was a problem hiding this comment.
So is this by line number in the COCO file or by string? If by line #, mention that in the readme. That's probably obvious to AI engineers but probably not for robotics engineers
Member
|
@tony23545 any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.