combine 'ws' and 'work space' pattern since Jenkins requires them to be non-empty#479
Merged
dirk-thomas merged 1 commit intomasterfrom Jun 17, 2020
Merged
Conversation
…be non-empty Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
nuclearsandwich
approved these changes
Jun 17, 2020
Member
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
Looking at the passing build, I don't think the wide-open glob presents a problem but if we see performance issues with the pattern match we could consider narrowing the pattern again.
| <id></id> | ||
| <name></name> | ||
| <pattern>@(workspace)/log/build_*/*/stdout_stderr.log</pattern> | ||
| <pattern>*/log/build_*/*/stdout_stderr.log</pattern> |
Member
There was a problem hiding this comment.
I was thinking something more precise like
Suggested change
| <pattern>*/log/build_*/*/stdout_stderr.log</pattern> | |
| <pattern>{ws,work space}/log/build_*/*/stdout_stderr.log</pattern> |
I think it only matters if we notice these globs taking a long time to resolve.
Member
Author
There was a problem hiding this comment.
I don't think that syntax is doing what you intend: which should have a compiler warning.
[GNU C Compiler (gcc)] [-ERROR-] No files found for pattern '{ws,work space}/log/build_//stdout_stderr.log'. Configuration error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression from #477 which fails build if there are no files matching the pattern.
The
antFileSetpattern doesn't support something like(foo|bar)afaik. Therefore I just matched any directory with*which shouldn't be a problem since the rest of the pattern is highly specific which shouldn't match anywhere else.Test builds: