Assume pre-configured environment variables instead of setup script for Connext#651
Draft
nuclearsandwich wants to merge 1 commit intomasterfrom
Draft
Assume pre-configured environment variables instead of setup script for Connext#651nuclearsandwich wants to merge 1 commit intomasterfrom
nuclearsandwich wants to merge 1 commit intomasterfrom
Conversation
…or Connext. The ROS 2 cookbook is setting environment variables used by rti_connext_dds_cmake_module and test_security. The Windows setup should check that those are set rather than overriding them with files found on the host.
Member
Author
|
Rolling |
clalancette
approved these changes
Mar 30, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks reasonable to me assuming that CI comes back green on Rolling, Galactic, and Foxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@clalancette reported these warnings showing up in the Windows builds:
The ROS 2 cookbook is setting environment variables used by rti_connext_dds_cmake_module and test_security. The Windows setup should check that those are set rather than overriding them with files found on the host.