Install nlohmann-json for Zenoh on Kilted and newer#810
Merged
Conversation
mjcarroll
approved these changes
Mar 28, 2025
Member
Author
|
ahcorde
previously requested changes
Apr 3, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Windows is not able to find it
CMake Error at CMakeLists.txt:19 (find_package):
By not providing "Findnlohmann_json.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"nlohmann_json", but CMake did not find one.
Could not find a package configuration file provided by "nlohmann_json"
with any of the following names:
nlohmann_jsonConfig.cmake
nlohmann_json-config.cmake
Member
|
We'll need to merge ros2/ros2#1666 for Windows jobs to succeed. |
Member
|
But even if we merge that in, we'll need to land #806 so that the Windows runner pulls the latest pixi.toml file. Else the runners which have already been spun up will continue to use cached pixi.toml file until they are manually restarted. |
Member
Author
|
It's pretty unergonomic to test these sorts of changes now, but here's a cobbled together windows build that uses ros2/ros2#1666 and exercises that change: Really, though, this PR only modifies the Linux Dockerfiles and so the Windows build is pretty irrelevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ros/rosdistro/blob/10cb92acc4de87e16237143554b230ebac1f73e6/rosdep/base.yaml#L7556-L7568