Add a pixi toml url to the build parameter arguments#839
Open
knmcguire wants to merge 11 commits intoros2:masterfrom
Open
Add a pixi toml url to the build parameter arguments#839knmcguire wants to merge 11 commits intoros2:masterfrom
knmcguire wants to merge 11 commits intoros2:masterfrom
Conversation
Generated-by: Claude Code Opus-4.5 (2025/11/01 release)
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: https://discourse.openrobotics.org/t/ros-pmc-minutes-for-january-20-2026/52015/1 |
Member
|
It looks like the "original" behavior determined the URL dynamically by substituting the ROS distro. When we trigger a job for a distribution other than Rolling, there's currently a bunch of job parameters that we need to change. Would it be possible to make the default value for this parameter empty, which will produce the existing behavior? There are certainly other parameters that should behave like this but don't, and it would be great to set a better precedent moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the location of the pixi.toml file is a bit hardcoded. See
ci/windows_docker_resources/Dockerfile
Line 53 in 15f43e0
This PR adds a CI_PIXI_TOML_URL parameter that will add an option to add an custom pixi.toml url (like in a gist). This allows us to test PRs like this one: ros2/ros2#1785 (this adds a version change to pixi.toml), and we would able to debug dependency issues without having to make a branch on the main ros2/CI repository for windows.
This is related to issue #832
Is this user-facing behavior change?
Yes, on ci.ros.org users can now see an new parameter called CI_PIXI_TOML_URL that they can fill in with another url as similar fasion as with CI_ROS2_REPOS_URL. But nothing should happen if they don't fill it in.
Did you use Generative AI?
Yes, only for one commit: 2ff6534
this was done with Claude Code (Opus 4.5)
Additional Information
I'll leave it in draft as I just want to double check things before merging (or have people look at it at least to see if I'm not breaking the whole CI!)