Explicitly add DLL directories for Windows before importing#266
Merged
jacobperron merged 2 commits intoros2from May 18, 2020
Merged
Explicitly add DLL directories for Windows before importing#266jacobperron merged 2 commits intoros2from
jacobperron merged 2 commits intoros2from
Conversation
Since Python 3.8, we should explicitly add DLL directories we recursively depend on. Use a helper context manager from rpyutils for adding directories from the PATH environment variable. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
May 16, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
I had to make a similar change for the c-extension being imported in the test 6f7c56a. |
nuclearsandwich
approved these changes
May 18, 2020
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.8, we should explicitly add DLL directories we recursively
depend on.
Use a helper context manager from rpyutils for adding directories from the PATH
environment variable.
Depends on ros2/rpyutils#2
Connects to ros2/ci#432