Replace deprecated spin_until_future_complete#667
Closed
christophebedard wants to merge 1 commit intoros2:rollingfrom
Closed
Replace deprecated spin_until_future_complete#667christophebedard wants to merge 1 commit intoros2:rollingfrom
christophebedard wants to merge 1 commit intoros2:rollingfrom
Conversation
Co-authored-by: Hubert Liberacki <hliberacki@gmail.com> Signed-off-by: Hubert Liberacki <hliberacki@gmail.com> Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
This was referenced Apr 2, 2024
ahcorde
approved these changes
Apr 2, 2024
christophebedard
changed the title
Member
Author
|
As per the discussion in ros2/rclcpp#2475 (comment), we will not be doing this. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #512
Requires ros2/rclcpp#2475
Requires ros2/rclpy#1268
Part of ros2/rclcpp#2475