Remove the import of Literal from entity.py.#694
Merged
clalancette merged 1 commit intorollingfrom Mar 6, 2023
Merged
Conversation
Literal is not supported in Python 3.6, which is what is in RHEL-8. Just remove this bit for now, since I don't actually believe it is needed anyway. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
mjcarroll
approved these changes
Mar 6, 2023
Contributor
Author
|
CI:
|
Contributor
Author
|
The unstable Windows build has been fixed elsewhere (ros2/rclcpp#2117). The unstable RHEL tests are known issues (but likely to go away when we switch to RHEL-9). So I'm going to go ahead and merge this in. |
Contributor
|
So in the context of launch, this ended up being fine but I needed the cast. The problem with removing literal and associated overloads is that you’re relaxing the type contract: when Let’s just hope we can stop supporting Python 3.6 soonish… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literal is not supported in Python 3.6, which is what is in RHEL-8. Just remove this bit for now, since I don't actually believe it is needed anyway.
This particular issue was introduced in #679 . FYI @haudren-woven @methylDragon