launch_yaml: cache and restore test environment#940
Open
launch_yaml: cache and restore test environment#940
Conversation
Several of the launch_yaml tests mutate the os.environ variable, which can yield some unexpected results depending on the sequence the tests are run. Use a fixture to cache and restore the original environment. Signed-off-by: Michael Carroll <carroll.michael@gmail.com>
mjcarroll
force-pushed
the
mjcarroll/test_sequence
branch
from
16f9ba4 to
dff1933
Compare
christophebedard
approved these changes
Jan 30, 2026
Member
Author
Probably something to discuss at PMC, but today @cottsay and I were spitballing the idea of randomizing test order in the buildfarm so that we can catch these implicit ordering issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of the launch_yaml tests mutate the os.environ variable, which can yield some unexpected results depending on the sequence the tests are run. Use a fixture to cache and restore the original environment.