Isolate tracing tests with private LTTng homes - #262
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
|
@sylvesterkaczmarek same here can you comply our AI guideline to disclose the information with using our PR template? and DCO is missing. |
Give test_ros2trace and test_tracetools_launch separate LTTNG_HOME values so their session daemons cannot interfere when package tests overlap. Remove the false dependency that serialized the two test packages. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
sylvesterkaczmarek
force-pushed
the
isolate-parallel-lttng-tests
branch
from
August 20, 2026 09:03
1eced48 to
e43d618
Compare
Author
|
@fujitatomoya Done, thanks. DCO is corrected and the PR description now follows the ROS 2 template. |
Contributor
this does not add up. why only 3 tests? can you share what test command did you execute and result? |
Contributor
|
@sylvesterkaczmarek btw, i saw you created other PRs, those do not comply the issue template and disclose of AI use. |
christophebedard
self-requested a review
August 27, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the serialization workaround between
test_ros2traceandtest_tracetools_launchby giving each package its own LTTng control state.tracetools_test.isolated_lttng_home()to create a privateLTTNG_HOMEtest_ros2tracedependency ontest_tracetools_launchThis allows the build farm to schedule the two packages in parallel without sharing the same LTTng session daemon.
Fixes #99
Is this user-facing behavior change?
Did you use Generative AI?
Yes. AI was used to assist with tests.
Additional Information
Testing performed:
PYTHONPATH=tracetools_test pytest -q tracetools_test/test/test_lttng.py→ 3 passedgit diff --check