Added ament_cmake_python package creation#1080
Open
bismuth01 wants to merge 2 commits intoros2:rollingfrom
Open
Added ament_cmake_python package creation#1080bismuth01 wants to merge 2 commits intoros2:rollingfrom
bismuth01 wants to merge 2 commits intoros2:rollingfrom
Conversation
ahcorde
requested changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working on the feature requested at #739 . Added a template argument and creation of the required folder structure for
--build-type cmake --template-name pythonIs this user-facing behavior change?
Now user can get a starting boilerplate where both python and cmake can be used in the same package.
Did you use Generative AI?
No, everything was reviewed, written and tested by hand.
Additional Information
It's still unclear how the
library-nameandnode-namearguments will interact with this template given the ambiguity of python and cmake.