Conversation
- ament/ament_package#164 - ros2#326 Signed-off-by: sunrisepeak <speakshen@163.com>
There was a problem hiding this comment.
(originally had meant to leave the comment here instead)
@Sunrisepeak - I ran your branch locally and the generation of package level fish scripts seems to be working well! I'm a bit confused about your testing setup, however. I would expect that by switching my rolling workspace's ament_package to this branch, that I would see a top level install/setup.fish inside my workspace's install folder, but that doesn't seem to be the case and your test script seems to manually add the setup.fish to /opt/ros/$DISTRO. Is adding the top level autogenerated setup.fish out of scope for this PR?
|
|
Pulls: ament/ament_package#164, #1211 |
|
@skyegalaxy the ci-unstable seem not related with the pr, Does it need to be rerun? |
Description
add support for fish
Is this user-facing behavior change?
improve for
fish shelluserDid you use Generative AI?
Additional Information